gh-74185: repr() of ImportError now contains attributes name and path. by serhiy-storchaka · Pull Request #1011 · python/cpython

serhiy-storchaka · 2017-04-05T22:30:48Z

Issue: repr() of ImportError misses keyword arguments name and path #74185

auvipy

re base plz

github-actions · 2022-02-19T00:08:25Z

This PR is stale because it has been open for 30 days with no activity.

github-actions · 2022-08-28T00:15:17Z

This PR is stale because it has been open for 30 days with no activity.

iritkatriel

This has merge conflicts now.

bedevere-bot · 2022-11-29T19:29:56Z

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

github-actions · 2022-12-31T00:09:47Z

This PR is stale because it has been open for 30 days with no activity.

github-actions · 2023-05-11T00:09:58Z

This PR is stale because it has been open for 30 days with no activity.

github-actions · 2024-02-05T00:10:55Z

This PR is stale because it has been open for 30 days with no activity.

MuhammadTausif · 2024-08-09T01:48:45Z

Why this PR is still open?

github-actions · 2024-09-08T12:03:19Z

This PR is stale because it has been open for 30 days with no activity.

encukou · 2024-12-19T16:16:40Z

@serhiy-storchaka, do you want to finish this PR? Should I take over?

github-actions · 2025-01-19T00:10:35Z

This PR is stale because it has been open for 30 days with no activity.

auvipy · 2025-02-13T06:35:32Z

@serhiy-storchaka, do you want to finish this PR? Should I take over?

I think you should take it over now

github-actions · 2025-03-15T18:03:02Z

This PR is stale because it has been open for 30 days with no activity.

johnzhou721 · 2025-05-18T19:06:46Z

Lib/test/test_exceptions.py

+        exc = ImportError('test', name='somename', path='somepath')
+        self.assertEqual(repr(exc),
+                "ImportError('test', name='somename', path='somepath')")
+


I'm not sure, but we might want a test that actually tries importing some nonexistent module and see if its __repr__ has those required attributes.

github-actions · 2025-06-18T00:11:16Z

This PR is stale because it has been open for 30 days with no activity.

bpo-29999: repr() of ImportError now contains attributes name and path.

025c980

the-knights-who-say-ni added the CLA signed label Apr 5, 2017

Fixed tests for repr() of exceptions with single argument.

318a5d8

serhiy-storchaka added the type-feature A feature request or enhancement label Apr 7, 2017

Merge branch 'master' into importerror-repr

b2d33e8

Mariatta added needs rebase and removed needs rebase labels Oct 9, 2017

brettcannon added the awaiting review label Feb 21, 2018

auvipy suggested changes May 31, 2019

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels May 31, 2019

github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 19, 2022

ezio-melotti removed the CLA signed label Jul 13, 2022

github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 28, 2022

github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 28, 2022

serhiy-storchaka mentioned this pull request Oct 29, 2022

repr() of ImportError misses keyword arguments name and path #74185

Closed

iritkatriel previously requested changes Nov 29, 2022

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting core review labels Nov 29, 2022

github-actions bot removed the stale Stale PR or inactive for long period of time. label Nov 30, 2022

github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 31, 2022

arhadthedev added 3 commits February 12, 2023 22:42

Use GitHub Actions version of Bedevere

60cde7b

Take a news entry from an outdated position

dcaccba

Merge branch 'main' into importerror-repr

9b5d0dc

arhadthedev changed the title ~~bpo-29999: repr() of ImportError now contains attributes name and path.~~ gh-74185: repr() of ImportError now contains attributes name and path. Feb 13, 2023

Add the news entry back

57f5024

bedevere-bot added awaiting core review and removed awaiting changes labels Apr 5, 2023

github-actions bot removed the stale Stale PR or inactive for long period of time. label Apr 6, 2023

github-actions bot added the stale Stale PR or inactive for long period of time. label May 11, 2023

Merge branch 'main' into importerror-repr

e9294a2

github-actions bot removed the stale Stale PR or inactive for long period of time. label Jan 6, 2024

github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 5, 2024

github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 9, 2024

github-actions bot added the stale Stale PR or inactive for long period of time. label Sep 8, 2024

github-actions bot removed the stale Stale PR or inactive for long period of time. label Dec 19, 2024

github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 19, 2025

github-actions bot removed the stale Stale PR or inactive for long period of time. label Feb 13, 2025

github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 15, 2025

This comment was marked as abuse.

Sign in to view

github-actions bot removed the stale Stale PR or inactive for long period of time. label Apr 23, 2025

johnzhou721 approved these changes May 18, 2025

View reviewed changes

github-actions bot added the stale Stale PR or inactive for long period of time. label Jun 18, 2025

Yoav11 mentioned this pull request Jul 19, 2025

gh-74185: repr() of ImportError now contains attributes name and path #136770

Merged

serhiy-storchaka closed this Aug 14, 2025

github-project-automation bot moved this from Waiting Done to Done in CPython pull requests to have finally merged Aug 14, 2025

serhiy-storchaka deleted the importerror-repr branch August 14, 2025 19:16

Uh oh!

Conversation

serhiy-storchaka commented Apr 5, 2017 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

auvipy left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 19, 2022

Uh oh!

github-actions bot commented Aug 28, 2022

Uh oh!

iritkatriel left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Nov 29, 2022

Uh oh!

github-actions bot commented Dec 31, 2022

Uh oh!

github-actions bot commented May 11, 2023

Uh oh!

github-actions bot commented Feb 5, 2024

Uh oh!

MuhammadTausif commented Aug 9, 2024

Uh oh!

github-actions bot commented Sep 8, 2024

Uh oh!

encukou commented Dec 19, 2024

Uh oh!

github-actions bot commented Jan 19, 2025

Uh oh!

auvipy commented Feb 13, 2025

Uh oh!

github-actions bot commented Mar 15, 2025

Uh oh!

This comment was marked as abuse.

johnzhou721 May 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

serhiy-storchaka commented Apr 5, 2017 •

edited by bedevere-bot

Loading